Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support schemas that don't use deferred FKs #1097

Closed
stephenh opened this issue May 19, 2024 · 1 comment · Fixed by #1100
Closed

Support schemas that don't use deferred FKs #1097

stephenh opened this issue May 19, 2024 · 1 comment · Fixed by #1100
Labels
released

Comments

@stephenh
Copy link
Collaborator

  • Probably topo sort by required FKs
  • Sort the order in metadata.ts somewhere
  • If a schema is using deferred FKs, don't sort / don't change any behavior
  • If cycles prevent insertion order, use dummy ids, and backfill in a 2nd clean-up flush
  • This probably places into support of non-SEQUENCE based databases
@stephenh stephenh mentioned this issue May 30, 2024
Merged
@stephenh
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.169.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support schemas with non-deferred FKs. joist-orm/joist-orm
1 participant
@stephenh