feat: Support schemas with non-deferred FKs. #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
force-pushed
the
feat-support-non-deferred-fks
branch
19 times, most recently
from
74ff45e
to
0e21cf4
Compare
stephenh
force-pushed
the
feat-support-non-deferred-fks
branch
from
0e21cf4
to
ce215c6
Compare
zgavin
approved these changes
May 29, 2024
| @@ -33,7 +33,7 @@ export class AuthorCodegen { | |||
| // ...all the boilerplate fields & m2o/o2m/m2m relations generated for you... | |||
| readonly books: Collection<Author, Book> = hasOne(...); | |||
| get firstName(): string { ... } | |||
| set firstName(): string { ... } | |||
| set firstName(value: string): string { ... } | |||
packages/codegen/src/index.ts
Outdated
|
|
||
| await writeAlterTables(nonDeferredFks); | ||
|
|
||
| if (setting === "error") hasError ??= true; |
There was a problem hiding this comment.
nit: just hasError = true?
| .filter((m2o) => m2o.notNull) | ||
| .forEach((m2o) => { | ||
| const added = addDependency(graph, entity, m2o); | ||
| if (Array.isArray(added)) notNullCylces.push(added.join(" -> ")); |
@zgavin totally agreed; my hope is that users will use the So just want to lower the bar/entry point, at least for PG setups. |
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
* feat: Support schemas with non-deferred FKs. * PR feedback. 3577c18
stephenh
pushed a commit
that referenced
this pull request
May 30, 2024
# [1.169.0](v1.168.2...v1.169.0) (2024-05-30) ### Features * Support schemas with non-deferred FKs. ([#1100](#1100)) ([3577c18](3577c18))
|
🎉 This PR is included in version 1.169.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Fixes #1097