Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix reacting to subtype-only relations. #1079

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: Fix reacting to subtype-only relations. #1079

merged 1 commit into from
May 8, 2024

Commits on May 8, 2024

  1. fix: Fix reacting to subtype-only relations. 

    If we saw a hint like:

* child (no subtypes) -> parent (that is a subtype) -> something else

When we would reverse it, and try to go:

* something else -> parent (that is a different subtype) -> children

The `parent[children]` would blow up, b/c that o2m may not exist.

This is very similar to conditionally walking through polys, so we
reuse the same `parent@Subtype` to infra to stop the walking before
trying to access `parent[children]`.
    @stephenh
    stephenh committed May 8, 2024
    Configuration menu
    Copy the full SHA
    38155f3 View commit details
    Browse the repository at this point in the history