Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fields.ts): fail not defined #1104

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

TylerR909
Copy link
Contributor

Line 21 is throwing this error:

    ReferenceError: fail is not defined

Instead of the correct Missing serde for myFieldName error.

It looks like an import was added last week for import { maybeRequireTemporal } from "./utils"; where there didn't used to be any imports from ./utils, so maybe it used to be getting this for free or from the environment somehow?

Copy link
Collaborator

@stephenh stephenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, jest "helpfully" adds it's fail to the global type scope, so this can sometimes fall through and not get caught. Thanks for the fix!

@stephenh stephenh merged commit c1708d6 into joist-orm:main Jun 4, 2024
5 checks passed
@TylerR909 TylerR909 deleted the fix/fail-not-defined branch June 4, 2024 01:24
stephenh pushed a commit that referenced this pull request Jun 4, 2024
## [1.169.2](v1.169.1...v1.169.2) (2024-06-04)

### Bug Fixes

* **undef:** fail not defined ([#1104](#1104)) ([c1708d6](c1708d6))
@stephenh
Copy link
Collaborator

stephenh commented Jun 4, 2024

🎉 This PR is included in version 1.169.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants