feat: Add hasReactiveAsyncProperty to fix reactivity on properties.

[stephenh]

Currently, reactive rules and reactive fields are allowed to depend on async properties.

There are tests for this behavior that verify the reactivity, however in retrospect they only covered reactivity due to gross mutations to the object graph, i.e. only fields that were present in the load hint.

For example, given an async property such as:

class BookReview {
  readonly isPublic2 = hasAsyncProperty("comment", br =>
    return !br.comment.get?.text.includes("Ignore");
  });
}

Any reactive rules/fields that depended on this isPublic2 would be recalculated if the BookReview.comment FK field ever changed, because comment existed in the load hint which Joist internally used as isPublic2's reactive hint.

However, any non-graph-mutating changes, such as simple changes to primitive fields that were used within the hasAsyncProperty lambda, would not trigger reactivity.

There are few different approaches to fix this:

1. Keep the "reactives rules/fields can use async properties w/just load hints" but embellish the load hint with every primitive the lamba could possibly read.

   I.e. a load hint like { book: "review" } would be embellished to be

   { book: { "title": {}, review: { "rating", "otherFieldA", "otherFieldB" } }
   

   Even if the lambda only accessed rating, any mutation to BookReview (even if rating is unchanged) would trigger potentially unnecessary reactivity/recalcs of dependent reactive rules/fields.

2. Break any current reactive rules/fields that use hasAsyncPropertys, and force them to instead write the property with a new hasReactiveAsyncProperty.

   The new hasReactiveAsyncProperty is semantically exactly the same as hasAsyncProperty, except that it takes a reactive hint, and hence it's lambda is forced to specify which fields it actually will access.

   Given that hasReactiveAsyncProperty has a user-provided reactive hint, there is no need for "embellishment", and we can hook up reactivity now with assurances that even primitive field changes will trigger the appropriate reactivity.

3. Require all hasAsyncPropertys to use a reactive hint instead of a load hint.

This PR implements the 2nd option.

[zgavin]

our poor tortured toy data model 😂

[stephenh]

our poor tortured toy data model

Lol, yes; this was like my 3rd attempt at "how do I least painfully slice this in as new fields/behavior" :-)

[stephenh]

🎉 This PR is included in version 1.74.0 🎉

The release is available on:

• v1.74.0
• GitHub release

Your semantic-release bot 📦🚀