Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert shortcuts into one menu using batch script #29

Merged
merged 6 commits into from
Mar 24, 2021
Merged

Convert shortcuts into one menu using batch script #29

merged 6 commits into from
Mar 24, 2021

Conversation

ODAKAB
Copy link
Contributor

@ODAKAB ODAKAB commented Mar 23, 2021

image

Copy link
Owner

@jojo2357 jojo2357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im really thankful that you put in the time to make this. However, I think the shortcuts should stay but rather a batch script should edit/create shortcuts so that the user can move those one-click shortcuts to their desktop, for example. This is what i thought you meant by your comments in #26. I understand it may take some time but im sure it can be done.

@ODAKAB
Copy link
Contributor Author

ODAKAB commented Mar 23, 2021

Sorry, I can't understand your concern, user can still create a shortcut of this script and place it anywhere. Why don't you think this as main launcher of your app?

@jojo2357
Copy link
Owner

I suppose but the idea I have in mind is that it should come out-of-the-box-one-click-to-run. If you could make a batch file or an option in the menu to create these shortcuts as to convenience the user, that would be absolutely perfect.

@ODAKAB
Copy link
Contributor Author

ODAKAB commented Mar 23, 2021

If It's possible to generate shortcuts, I will try. Do you want it as an extra or default?
If you want it as an extra, It can be option 10 that generates all options as shortcuts in Shortcuts folder.
Or like 9 new options that generates shortcut for specified option.
I can also seperate ShortcutGenerator

@jojo2357
Copy link
Owner

I think having a shortcut generator bat plus an option in the menu that calls it would be the best option here so the user could hypothetically two clicks to run.

@ODAKAB
Copy link
Contributor Author

ODAKAB commented Mar 23, 2021

Reminding that option 10 doesn't need to call another batch script, as i can directly code it into script too.
Calling would be for having a standalone ShortcutGenerator file.

@jojo2357
Copy link
Owner

Im aware. I was just hoping that the user could have a single click to fix the shortcuts with the option to do it in the menu as well. The launcher could go in the root directory as well and leave the shortcuts in their folder.

@ODAKAB ODAKAB marked this pull request as draft March 23, 2021 03:14
@ODAKAB ODAKAB marked this pull request as ready for review March 23, 2021 04:00
@ODAKAB ODAKAB requested a review from jojo2357 March 23, 2021 04:00
@ODAKAB
Copy link
Contributor Author

ODAKAB commented Mar 23, 2021

Generated shortcuts aren't set to run as administrator, couldn't find how to do it.
https://www.vbsedit.com/html/e6ac108b-15f6-4a54-891f-589e8b687ace.asp

@jojo2357
Copy link
Owner

Okay and my other concern is that running the linkers, finders, and unlinkers all require admin perms so would there be a way to gain admin perms when the user selects it? also making the shortcuts using admin perms is a must.

A possible option for solving admin issue for shortcuts:
https://superuser.com/questions/1440665/create-windows-shortcut-with-run-as-administrator-option-enabled

@ODAKAB
Copy link
Contributor Author

ODAKAB commented Mar 23, 2021

MusicDRP script already requests for admin permissions on start, and that passes to called scripts.
I checked the topic you sent, actually I tried to use HxD on .lnk but It just gave me where it pointed to. Seems like they also thought a workaround like me and editing file in hex.
I liked this solution but I'm a bit busy today and tomorrow. Feel free to merge and finish setting run as admin on shortcuts if you want, because I will start working back a bit late.

Menu doesnt require admin, c# creates shortcuts in order to have the right icons, remove the finder shortcuts because most people only have to run them once anyway and any bat that needs admin will demand it instead of needing shortcuts with admin
@jojo2357
Copy link
Owner

I made some changes please review most recent commit

@jojo2357
Copy link
Owner

Im going to merge and if you would like to make changes after, feel free to open a new pr.

@jojo2357 jojo2357 merged commit f1e1019 into jojo2357:master Mar 24, 2021
@RoguedBear
Copy link

I tested the Music_DRP_Launcher.bat, when I selected the 0 option the shortcuts folder was not created, but when I selected 2nd option Launch DRP, The shortcuts/ folder was generated also opening the GroovyRP.exe

@jojo2357
Copy link
Owner

Hmmm the create option is supposed to run mdrp actually since the shortcut creation is in the exe. Ill look into it thanks

@RoguedBear
Copy link

RoguedBear commented Mar 25, 2021

Also noticed one more thing. Link/Unlink options [4 to 7] error out with 'D:\Portable' is not recognized as an internal or external command, operable program or batch file. when there are spaces in the repository path just like how it happened in #16

Edit: The shortcuts bug out too, except the Run MDRP... & KIllHidden.vbs shortcuts

@jojo2357
Copy link
Owner

not this again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants