Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct fake-factory package links to point to Faker #20

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Correct fake-factory package links to point to Faker #20

merged 1 commit into from
Jan 30, 2023

Conversation

jeffwidman
Copy link
Contributor

fake-factory moved to Faker on Pypi, with a minimum version of 0.7.3:
joke2k/faker#331

@jeffwidman
Copy link
Contributor Author

cc @fcurella - not sure if you have commit rights here

@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage remained the same at 93.313% when pulling 557e953 on jeffwidman:rename-fake-factory-to-faker into 345e3ee on joke2k:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.313% when pulling 557e953 on jeffwidman:rename-fake-factory-to-faker into 345e3ee on joke2k:master.

fake-factory moved to Faker on Pypi, with a minimum version of 0.7.3:
joke2k/faker#331
@coveralls
Copy link

coveralls commented Sep 19, 2016

Coverage Status

Coverage remained the same at 93.313% when pulling 833a922 on jeffwidman:rename-fake-factory-to-faker into 345e3ee on joke2k:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.313% when pulling 833a922 on jeffwidman:rename-fake-factory-to-faker into 345e3ee on joke2k:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.313% when pulling 833a922 on jeffwidman:rename-fake-factory-to-faker into 345e3ee on joke2k:master.

@fcurella
Copy link

@jeffwidman I dont have commit rights here, you'll have to get @joke2k involved

@jeffwidman
Copy link
Contributor Author

ping @joke2k

@jeffwidman
Copy link
Contributor Author

Bump @joke2k

@jeffwidman
Copy link
Contributor Author

ping @joke2k

@jeffwidman
Copy link
Contributor Author

Bump @joke2k

@jeffwidman
Copy link
Contributor Author

nudge @joke2k

1 similar comment
@jeffwidman
Copy link
Contributor Author

nudge @joke2k

@jeffwidman
Copy link
Contributor Author

@joke2k can you take a look at this one too? Also fixing a URL...

@joke2k
Copy link
Owner

joke2k commented Jan 30, 2023

@joke2k can you take a look at this one too? Also fixing a URL...

I suppose that is passed enough time XD

@joke2k joke2k merged commit a5954a5 into joke2k:master Jan 30, 2023
@jeffwidman jeffwidman deleted the rename-fake-factory-to-faker branch January 30, 2023 20:25
@jeffwidman
Copy link
Contributor Author

This does win the prize for the longest a PR of mine sat open before being merged. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants