-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added an "Invalid SSN" generator to the en_US SSN Provider
- Loading branch information
1 parent
9071f74
commit c412d56
Showing
3 changed files
with
161 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,3 +48,5 @@ nosetests.xml | |
|
||
# IDE | ||
*.sw[po] | ||
*.iml | ||
*.ipr |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c412d56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When initializing the
itin_group_numbers
wouldn't it be clearer to do something like this:or even use the list as you have it but put comment out lines for 89 and 93 like this:
c412d56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swehba since it's a predefined list, it's fine to have it statically hardcoded. Another added benefit is micro-optimization: although the benefit is arguably negligible, a hardcoded list is less computationally expensive then one we have to compute.
Either way we're really splitting hair, there isn't much practical difference between the two approaches. The real reason the list is hardcoded is because someone submitted the code this way, and it was good enough :)
c412d56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.