New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locale fr_FR : phone_number generate invalid values #1516
Comments
Thank you for the report, @zerbusdetroy ! Do you have time to work on a Pull Request? |
Yes I can. I do it next week :)
-------- Message d'origine --------De : Flavio Curella ***@***.***> Date : 23/09/2021 12:45 (GMT+01:00) À : joke2k/faker ***@***.***> Cc : Zerbus ***@***.***>, Mention ***@***.***> Objet : Re: [joke2k/faker] Locale fr_FR : phone_number generate invalid values (#1516)
Thank you for the report, @zerbusdetroy !
Do you have time to work on a Pull Request?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I found another issue, phone numbers starting with 07 are not included (exist since 2010, so "relatively" new). |
nicarl
added a commit
to nicarl/faker
that referenced
this issue
Oct 22, 2021
French landline numbers (starting with 01, 02, 03, 04, 05) are limited to well-known area codes. This is taken into account when generating the phone numbers. Mobile phone numbers starting with 07 are also added. Fixes: joke2k#1516
nicarl
added a commit
to nicarl/faker
that referenced
this issue
Oct 22, 2021
French landline numbers (starting with 01, 02, 03, 04, 05) are limited to well-known area codes. This is taken into account when generating the phone numbers. Mobile phone numbers starting with 07 are also added. Fixes: joke2k#1516
nicarl
added a commit
to nicarl/faker
that referenced
this issue
Oct 23, 2021
French landline numbers (starting with 01, 02, 03, 04, 05) are limited to well-known area codes. This is taken into account when generating the phone numbers. Mobile phone numbers starting with 07 are also added. Fixes: joke2k#1516
fcurella
pushed a commit
that referenced
this issue
Oct 27, 2021
French landline numbers (starting with 01, 02, 03, 04, 05) are limited to well-known area codes. This is taken into account when generating the phone numbers. Mobile phone numbers starting with 07 are also added. Fixes: #1516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The phone_number default provider generate random numbers after the first 2 digits (01 ## ## ## ##, etc.).
A lot of combinaisons are not possible for the digits 3 and 4 depending of the first 2. The complete list is available here.
For example 0415919107 is valid while 0405919107 is not.
This make this provider incompatible with phonenumbers, a lib for phone number validations.
Steps to reproduce
Faker("phone_number", locale="fr_FR").generate()
Expected behavior
0405919107 should never be generated because its invalid
Actual behavior
0405919107 can be generated
The text was updated successfully, but these errors were encountered: