-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: OverflowError on i686 and mips64el #408
Comments
See: |
So can you please disable the respective tests on i686? |
Disabling tests is a bad idea since it covers problems. The bug is caused by this line creating a value which not accepted at these platforms:
The same problem theoretically exists in The solution is to use
Same for Maybe you also want to issue a warning if this case occurs. |
|
Oh, well, this might analysis might be wrong: |
I can switch behavior for 32bit system to something like solution suggested by @htgoebel. What should the max year be on 32bit systems? |
Depending this on 32-bit is dangerous and wrong: mips64el is 64-bit. I'm afraid you need to have a deeper look into your code to find out where you query the boundary. |
TODO: remove this as we get closer to 9999
TODO: remove this as we get closer to 9999
TODO: remove this as we get closer to 9999
Close #408. Cap years to 9999 to support 32-bit platforms
test_date_time_this_period and test_date_time_this_period_with_tzinfo fail on i686 and mips64el. For details please see
The text was updated successfully, but these errors were encountered: