-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added es_PE person #1844
Added es_PE person #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some test cases for the new providers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can yuou fix the remaining linting issue? You can run make lint
to format using the project's settings.
@fcurella When I run black it tells me there is 1 file that needs to be reformatted but when i format it it tells me no changes were made.
|
@JsonVladimir I'm not seeing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the failing tests?
tests/providers/test_bank.py
Outdated
iban = faker.iban() | ||
assert is_valid_iban(iban) | ||
assert iban[:2] == EsPeBankProvider.country_code | ||
assert re.fullmatch(r"\d{2}[A-Z]{4}}\d{18}", iban[2:]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I see an extra }
in {4}}
class TestEsPE: | ||
"""Test es_PE phone number provider methods""" | ||
|
||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we actually test something? :P
Added es_PE to person, I recently used the library and noticed that there were no common names from Peru, I decided to propose that the file be added.