Improve fr_FR provider postcode #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Apr 24, 2023
tonial
force-pushed
the
alaurent/improve_french_postcode
branch
from
a90e0e9
to
4d72728
Compare
|
we could just check that the first 2 characters are a valid department code? Better than nothing :) |
tonial
force-pushed
the
alaurent/improve_french_postcode
branch
from
4d72728
to
0187102
Compare
|
I added the check. |
fcurella
reviewed
May 2, 2023
fcurella
requested changes
May 2, 2023
tonial
force-pushed
the
alaurent/improve_french_postcode
branch
from
0187102
to
0eac3af
Compare
|
I fixed it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Improve postcode for fr_FR address provider
What was wrong
The current provider may generate postcodes for invalid departments (any number starting with 96 is invalid)
How this fixes it
Generate postcode from department codes
NB: I'm not sure how to test this commit : I could check that the generated postcode always match a department, but the test would be flaky before the fix...