Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xml generator #1862

Merged
merged 10 commits into from
May 16, 2023
Merged

Feature/xml generator #1862

merged 10 commits into from
May 16, 2023

Conversation

Elihayb
Copy link
Contributor

@Elihayb Elihayb commented May 8, 2023

What does this change

Add XML provider for generating fake xml strings.
Use the pydict provider and arguments and convert it onto xml string via xmltodict library

@Elihayb Elihayb mentioned this pull request May 8, 2023
faker/providers/misc/__init__.py Outdated Show resolved Hide resolved
faker/providers/misc/__init__.py Outdated Show resolved Hide resolved
tests/providers/test_misc.py Outdated Show resolved Hide resolved
@fcurella
Copy link
Collaborator

fcurella commented May 8, 2023

Can you run make lint to fix the formatting?

faker/providers/misc/__init__.py Outdated Show resolved Hide resolved
faker/providers/misc/__init__.py Outdated Show resolved Hide resolved
tests/providers/test_misc.py Outdated Show resolved Hide resolved
Elihayb and others added 5 commits May 10, 2023 08:42
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
Co-authored-by: Flavio Curella <89607+fcurella@users.noreply.github.com>
@Elihayb Elihayb requested a review from fcurella May 10, 2023 14:29
@Elihayb
Copy link
Contributor Author

Elihayb commented May 16, 2023

Can you run make lint to fix the formatting?

@fcurella Can you please review the changes? I increased the coverage and ran the lint

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 5a61a05 into joke2k:master May 16, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants