Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weigthing to dynamic providers #1894

Merged

Conversation

pauldechorgnat
Copy link
Contributor

What does this change

DynamicProvider now accept weighted elements if provided an OrderedDict

What was wrong

DynamicProvider were not taking weights into account.

See Issue #1892

Also fixes a C419 flake8 error on a test file.

Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit b05eec7 into joke2k:master Aug 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants