Access current_time_adapter in runtime instead of compile time #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue joken-elixir#236 I tried using Mox to inject a Joken.CurrentTime.Mock instance but because the way Joken was accessing the adapter using module attributes which are resolved at compile time instead of runtime. And because the Joken module is already compiled when we pull it as a dependency, the adapter was always using the `Joken.CurrentTime.OS` in test. By using a private function to access the adapter, we make sure that the adapter is resolved at runtime.
victorolinasc
approved these changes
Nov 9, 2019
|
Thanks! Much appreciated! Sorry for the long wait... Did not know this would be such a wanted feature... sorry for my hindsight! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #236
I tried using Mox to inject a
Joken.CurrentTime.Mockinstance but it did not work because the way Joken was accessing the adapter using module attributes which are resolved at compile time instead of runtime.By using a private function to access the adapter, we make sure that the adapter is resolved at runtime.