Address unmatched return warnings from Dialyzer #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you
use JokenJwks.DefaultStrategyTemplate
in your own code and run dialyzerto check with
-Wunmatched_returns
, three warnings appear on the line whereuse
was put. Addinglocation: :keep
to thequote
inJokenJwks.DefaultStrategyTemplate
reveals the following lines:This commit resolves the above warnings as following (respectively):
:ets.new/2
uses the:named_table
option, and so should alwaysreturn the atom that was passed as the table name, namely
__MODULE__
.start_fetch_signers/2
has the same return type asTask.start/1
, which is{:ok, pid()}
, so we match on{:ok, _}
.check_fetch
could return:ok
or{:ok, pid()}
based on thebranches of the
case
expression inside the function. Since there weren't anysimple ways to resolve this, I chose to match with
_
.