Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28 Refactoring: Modal Component #29

Merged
merged 1 commit into from
Jan 8, 2021
Merged

#28 Refactoring: Modal Component #29

merged 1 commit into from
Jan 8, 2021

Conversation

jokiefer
Copy link
Owner

@jokiefer jokiefer commented Jan 8, 2021

  • implements the in Refactoring: Modal component #28 described feature for fetch_url
  • implemention on top of Refactoring: Modal component #28:
  • split Modal in ModalHeader, ModalBody, ModalFooter components
  • refactors the render_item function. Now it is possible to render Modal component and his child button
  • refactors all needed tests

@jokiefer
#28 Refactoring: Modal Component
e7c5408 
* implements the in #28 described feature for fetch_url
* implemention on top of #28:
 * split Modal in ModalHeader, ModalBody, ModalFooter components
 * refactors the render_item function. Now it is possible to render Modal component and his child button 
 * refactors all needed tests
@jokiefer jokiefer merged commit 50d95d3 into main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jokiefer