Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for simple features (sf) objects #2

Closed
kent37 opened this issue Apr 12, 2020 · 2 comments
Closed

Support for simple features (sf) objects #2

kent37 opened this issue Apr 12, 2020 · 2 comments

Comments

@kent37
Copy link
Contributor

kent37 commented Apr 12, 2020

Hi, this looks like a useful package. Would you consider adding support for simple features classes from package sf? I'd be happy to make a pull request, there is working code (needing tests) in my fork.
@jolars
Copy link
Owner

jolars commented Apr 13, 2020

Hm, sure, I think that might be a reasonable extension. I'd be happy to consider a pull request.

jolars added a commit that referenced this issue Apr 18, 2020
@jolars
Merge pull request #3 from kent37/issue2
f789a6a 
Add support for simple features objects (#2)
@jolars
Copy link
Owner

jolars commented Apr 18, 2020

Fixed in #3

@jolars jolars closed this as completed Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kent37 @jolars