Merge pull request #10 from lovedboy/master

To be efficient in Go, minimize memory allocations

collections/collections.go

@@ -58,9 +58,11 @@ func (this *SyncIdentityMap) Size() int {
 func (this *SyncIdentityMap) Values() []interface{} {
 	this.RLock()
 	defer this.RUnlock()
-	var list []interface{}
+	list := make([]interface{}, len(this.m))
+	i := 0
 	for _, v := range this.m {
-		list = append(list, v)
+		list[i] = v
+		i++
 	}
 	return list
 }

collections/collections_test.go

@@ -31,6 +31,19 @@ func TestSyncMapString(t *testing.T) {
 	assert.Nil(t, m.Get(&key))
 }
 
+func TestSyncMapValues(t *testing.T) {
+	m := NewSyncMap()
+	key := "key"
+	key2 := "key2"
+	m.Put(&key, "value1")
+	m.Put(&key2, "value2")
+	values := m.Values()
+	assert.Equal(t, 2, len(values))
+	assert.Equal(t, "value1", values[0])
+	assert.Equal(t, "value2", values[1])
+
+}
+
 func TestSyncMapHashableObject(t *testing.T) {
 	m := NewSyncMap()
 	o1 := HashableObject{}