Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes for Switzerland are not correct #46

Closed
georgobermayr opened this issue Jun 22, 2019 · 3 comments · Fixed by #47
Closed

Quotes for Switzerland are not correct #46

georgobermayr opened this issue Jun 22, 2019 · 3 comments · Fixed by #47

Comments

@georgobermayr
Copy link

Hi,

the quotes for the de-CH locale are not set correctly. The quotes for Germany and Austria are applied wich is not correct for Switzerland. In Switzerland they use French-style angle quotation marks, see: https://en.wikipedia.org/wiki/Quotation_mark#German

In Switzerland, however, the French-style angle quotation mark sets are also used for German printed text: «A ‹B›?»
Andreas fragte mich: «Hast du den Artikel ‹EU-Erweiterung› gelesen?»
Andreas asked me: ‘Have you read the “EU Expansion” article?’

@damienalexandre
Copy link
Member

Thanks for the feedback!

This exception can be added here:

switch (strtolower($locale)) {
// “…”
case 'pt-br':
$this->opening = Fixer::LDQUO;
$this->openingSuffix = '';
$this->closing = Fixer::RDQUO;
$this->closingPrefix = '';
return;
}

Would you like to suggest a pull request?

@georgobermayr
Copy link
Author

Thank you! Pull request is ready for review.

@damienalexandre
Copy link
Member

Thanks, I just release version 1.0.5 with your fix!
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants