Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated usage of tree builder where possible #43

Merged
merged 1 commit into from Apr 9, 2019
Merged

Remove deprecated usage of tree builder where possible #43

merged 1 commit into from Apr 9, 2019

Conversation

killerwolf
Copy link
Contributor

should fix #42

@killerwolf
Copy link
Contributor Author

i might put something like this, with less boilerplate code (like monolog does)

$treeBuilder = new TreeBuilder('monolog');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('monolog');

@lyrixx lyrixx merged commit 772fcde into jolicode:master Apr 9, 2019
@lyrixx
Copy link
Member

lyrixx commented Apr 9, 2019

Thanks for working on it

@killerwolf killerwolf deleted the fix-tree-builder-deprecation branch April 17, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deprecation in tree builder for Symfony 4.2+
2 participants
@killerwolf @lyrixx