Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of tree builder where possible #43

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@killerwolf
Copy link
Contributor

killerwolf commented Apr 5, 2019

should fix #42

@killerwolf

This comment has been minimized.

Copy link
Contributor Author

killerwolf commented Apr 8, 2019

i might put something like this, with less boilerplate code (like monolog does)

$treeBuilder = new TreeBuilder('monolog');
$rootNode = method_exists(TreeBuilder::class, 'getRootNode') ? $treeBuilder->getRootNode() : $treeBuilder->root('monolog'); 
@lyrixx

lyrixx approved these changes Apr 9, 2019

@lyrixx lyrixx merged commit 772fcde into jolicode:master Apr 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lyrixx

This comment has been minimized.

Copy link
Member

lyrixx commented Apr 9, 2019

Thanks for working on it

@killerwolf killerwolf deleted the killerwolf:fix-tree-builder-deprecation branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.