Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: add phpDoc in mappers #37

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

nikophil
Copy link
Collaborator

@nikophil nikophil commented Jan 18, 2024

This PR adds some phpdoc in generated mappers, which could be useful when debugging:

example:

    /** @param array $value */   <== phpdoc added here
    public function &map($value, array $context = array()) : mixed
    {
        if (null === $value) {
            return $value;
        }
        /** @var \AutoMapper\Tests\Fixtures\AddressDTOSecondReadonlyClass $result */    <== and here
        $result = $context['target_to_populate'] ?? null;
       
        // ...
    }

Copy link
Member

@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a quick note in CHANGELOG and fix the coding style issue ? 🙏

@nikophil nikophil force-pushed the minor/add-phpdoc-in-mappers branch 2 times, most recently from deda215 to 21702e4 Compare January 19, 2024 09:05
@Korbeil
Copy link
Member

Korbeil commented Jan 19, 2024

Thanks for your contribution @nikophil ! 🙏

@Korbeil Korbeil merged commit d92720a into jolicode:main Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants