feat(generator): allow skipping uninitialized property when skipping null values #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/allow-to-skip-uninit-props
branch
from
3629c12
to
53fc76f
Compare
joelwurtz
force-pushed
the
feat/allow-to-skip-uninit-props
branch
from
53fc76f
to
94cf750
Compare
joelwurtz
commented
Mar 8, 2024
nikophil
reviewed
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43
Instead of getting the value we do a check on whether the value is null or undefined, this allow skipping mapping uninitialized property also.
Without this change it php would throw an error as we try to get a uninitialized property value