fix(transformer): change the way transformer factory are injected to make it work as soon as automapper is created #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/transformer-factory-aware
branch
from
42f2464
to
12b7361
Compare
Korbeil
approved these changes
Mar 9, 2024
joelwurtz
force-pushed
the
feat/transformer-factory-aware
branch
from
12b7361
to
256eb4c
Compare
…make it work as soon as automapper is created
joelwurtz
force-pushed
the
feat/transformer-factory-aware
branch
from
256eb4c
to
18a9f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #4
Mainly the issue is we don't know in which order the process / addTransformerFactory will be done in the DIC of Symfony.
To havoid doing something complicated in the bundle i change the way factories are created.
So now they can be created before the automapper, and registry / chain transformer will be set when they are injected.
This also allow only implementating an interface to have the registry / chain set and will simplify DIC configuration in the bundle
Now when we do
new AutoMapper()it should be ready instantly