fix: mapPrivatePropertiesAndMethod should not be mandatory #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
force-pushed
the
fix/private-property
branch
from
e1dce7d
to
1e62341
Compare
nikophil
force-pushed
the
fix/private-property
branch
from
1e62341
to
90357df
Compare
nikophil
commented
Oct 22, 2023
| @@ -87,7 +87,7 @@ public function getPropertiesMapping(MapperMetadataInterface $mapperMetadata): a | |||
| $this->getMaxDepth($mapperMetadata->getSource(), $property), | |||
| $this->isIgnoredProperty($mapperMetadata->getSource(), $property), | |||
| $this->isIgnoredProperty($mapperMetadata->getTarget(), $property), | |||
| PropertyReadInfo::VISIBILITY_PUBLIC === $this->readInfoExtractor->getReadInfo($mapperMetadata->getSource(), $property)?->getVisibility() ?? true, | |||
| PropertyReadInfo::VISIBILITY_PUBLIC === ($this->readInfoExtractor->getReadInfo($mapperMetadata->getSource(), $property)?->getVisibility() ?? PropertyReadInfo::VISIBILITY_PUBLIC), | |||
There was a problem hiding this comment.
🤭
this would have been detected by phpstan 😇
nikophil
commented
Oct 22, 2023
| @@ -229,7 +229,8 @@ private function buildPropertyMapping(): void | |||
| null, | |||
| new CallbackTransformer($property), | |||
| $property, | |||
| false | |||
| false, | |||
| isPublic: true, | |||
There was a problem hiding this comment.
because we're in presence of custom mapping, I think we should consider it as public, other wise PropertyMapping::shouldIgnoreProperty() will return true
Korbeil
approved these changes
Oct 23, 2023
nikophil
force-pushed
the
fix/private-property
branch
from
90357df
to
6c7d1d2
Compare
Korbeil
reviewed
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapPrivatePropertiesAndMethodmachanism was buggy, this is now fixed