Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the documentation #226

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Refactor the documentation #226

merged 1 commit into from
Jan 11, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Jan 10, 2024 •
edited

@pyrech pyrech force-pushed the doc-refacto branch 4 times, most recently from 7c3c02e to 56b8439 Compare January 11, 2024 12:46
@pyrech pyrech marked this pull request as ready for review January 11, 2024 12:48
lyrixx
lyrixx reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I let some comments, but easy to address.

Thanks

doc/going-further/advanced-context.md Outdated Show resolved Hide resolved
doc/going-further/advanced-context.md Show resolved Hide resolved
doc/going-further/advanced-context.md Show resolved Hide resolved
doc/going-further/cache.md Outdated Show resolved Hide resolved
doc/going-further/http-request.md Outdated Show resolved Hide resolved
@pyrech pyrech force-pushed the doc-refacto branch 5 times, most recently from 532da38 to c54ffe1 Compare January 11, 2024 14:27
@lyrixx
Copy link
Member

lyrixx commented Jan 11, 2024

Thanks for this amazing work 😍

@lyrixx lyrixx merged commit a09e46f into main Jan 11, 2024
3 checks passed
@lyrixx lyrixx deleted the doc-refacto branch January 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pyrech @lyrixx