Refactor how the application is wired #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, the was many duplicated parts. There was some logic in the
GlobalHelper
class, and a bit everywhere else in the application, like in theApplication
, or theContextRegistry
. More over, there was too much staticcall from class living in
src/
to some castor's functions orGlobalHelper
.This patch clean this. Now there are DI everywhere, no more static call in our
domain!
Since the application is the heart of castor, this class hold everything!
Everything rely on DI and should stay like this.
The
GlobalHelper
is now a simple proxy to the application, with some convenientmethods. And it should stay like this also.