Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how the application is wired #227

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Refactor how the application is wired #227

merged 1 commit into from
Jan 11, 2024

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 11, 2024

Before this patch, the was many duplicated parts. There was some logic in the
GlobalHelper class, and a bit everywhere else in the application, like in the
Application, or the ContextRegistry. More over, there was too much static
call from class living in src/ to some castor's functions or GlobalHelper.

This patch clean this. Now there are DI everywhere, no more static call in our
domain!

Since the application is the heart of castor, this class hold everything!
Everything rely on DI and should stay like this.

The GlobalHelper is now a simple proxy to the application, with some convenient
methods. And it should stay like this also.

@lyrixx lyrixx requested a review from pyrech January 11, 2024 10:08
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner, thanks

@pyrech pyrech merged commit df96c3f into main Jan 11, 2024
3 checks passed
@pyrech pyrech deleted the refacto branch January 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants