Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix section output to work on Windows #275

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix section output to work on Windows #275

merged 1 commit into from
Feb 9, 2024

Conversation

pyrech
Copy link
Member

@pyrech pyrech commented Feb 9, 2024 •
edited

  • posix_isatty() does not work on Windows, but stream_isatty() seems to work on Windows
  • first check if we want to use section before calling this function

lyrixx
lyrixx approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck with that !

@lyrixx lyrixx merged commit 7c108f2 into main Feb 9, 2024
7 checks passed
@lyrixx lyrixx deleted the fix-section-output-windows branch February 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pyrech @lyrixx