feat(timeout): Remove the default timeout of 60s #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
I agree that the timeout is sometime an issue so I vote for removing it 👍
Could you please:
- add a note in the changelog
- change the documentation: https://castor.jolicode.com/getting-started/run/#timeout
Thanks
pyrech
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see myself having to customise my context too often.
There is no point in having a command timeout on a build tool.
Makefile does not have timeout for example. I think NULL is a better default value.