feat: add bash-installer #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
approved these changes
Mar 29, 2024
installer/bash-installer
Outdated
Comment on lines
111
to
113
| output " [*] PHP version >= 8.1" "success" | ||
| else | ||
| output " [ ] ERROR: PHP version is not 8.1 or greater" "error" |
There was a problem hiding this comment.
Should we display the current detected PHP version (in both success and error cases)? Fe in case the user has several versions installed, it could help to understand the issue. WDYT ?
Co-authored-by: Lo茂ck Piera <pyrech@gmail.com>
tucksaun
force-pushed
the
feat/bash-installer
branch
from
5091edc
to
47f1856
Compare
lyrixx
approved these changes
Apr 1, 2024
|
Thanks you very much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because during his talk @lyrixx mentioned the wish to have one similar to the one from Symfony CLI, here is a PR for a first iteration.
This script is mainly extracted from the Symfony CLI and adapted for 馃Λ Castor.
Can currently be tested using
curl "https://raw.githubusercontent.com/tucksaun/castor/feat/bash-installer/installer/bash-installer" | bash