Add support for mounting another castor app #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Apr 2, 2024
•
lyrixx
commented
joelwurtz
reviewed
Apr 2, 2024
|
I like the approach, and it seems to meet the need for an issue I opened some time ago! :) |
Love it, made a proposition, it's only a namespace isn't it ? |
|
I like the idea 👍 |
lyrixx
force-pushed
the
mount
branch
2 times, most recently
from
01719f9
to
b7faa34
Compare
lyrixx
commented
Apr 2, 2024
Comment on lines
9
to
11
| import(__DIR__ . '/tools/php-cs-fixer/castor.php'); | ||
| import(__DIR__ . '/tools/phpstan/castor.php'); | ||
| import(__DIR__ . '/tools/static/castor.php'); |
There was a problem hiding this comment.
For the record, theses "app" cannot be mounted, since they refer to configuration in at the root (see the doc)
pyrech
reviewed
Apr 2, 2024
pyrech
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.