Refactor the whole application kernel #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 7, 2024
lyrixx
changed the title
lyrixx
force-pushed
the
kernel
branch
2 times, most recently
from
3239e86
to
8952897
Compare
lyrixx
force-pushed
the
kernel
branch
2 times, most recently
from
7124437
to
2b6c0ba
Compare
lyrixx
changed the title
lyrixx
commented
Apr 8, 2024
| @@ -78,6 +79,7 @@ private static function configureDebug(): ErrorHandler | |||
|
|
|||
| AbstractCloner::$defaultCasters[self::class] = ['Symfony\Component\VarDumper\Caster\StubCaster', 'cutInternals']; | |||
| AbstractCloner::$defaultCasters[AfterApplicationInitializationEvent::class] = ['Symfony\Component\VarDumper\Caster\StubCaster', 'cutInternals']; | |||
| AbstractCloner::$defaultCasters[DescriptorsCollection::class] = ['Symfony\Component\VarDumper\Caster\StubCaster', 'cutInternals']; | |||
There was a problem hiding this comment.
Much better display when running castor -vvv
pyrech
approved these changes
Apr 8, 2024
Is there any way to forbid it? I think it could lead to security issues (someone publish a castor random task that sounds useful, but this task import another one (repeat N times) and the last one contain malicious code. |
Indeed, but it's already the case with a "simple" import. I mean, this PR does not allow more security issue than the one already present |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importfrom a git repository #395