Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(symfony): Provide a working example out of the box #152

Merged
merged 1 commit into from
Feb 17, 2023
Merged

doc(symfony): Provide a working example out of the box #152

merged 1 commit into from
Feb 17, 2023

Conversation

damienalexandre
Copy link
Member

@damienalexandre damienalexandre commented Feb 17, 2023 •
edited by lyrixx
Loading

The example in the documentation was not working out of the box.

The HttpClientTransport MUST be declared first:

JoliCode\Elastically\Transport\HttpClientTransport: ~

So I think it's better to comment it out.

Also, what about forcing this transport when using Symfony?!

@lyrixx
Copy link
Member

lyrixx commented Feb 17, 2023 •
edited
Loading

Also, what about forcing this transport when using Symfony?!

nope :) you probably one specific http client, not the default one

@lyrixx lyrixx merged commit 6321c32 into master Feb 17, 2023
@lyrixx lyrixx deleted the damienalexandre-patch-1 branch February 17, 2023 14:13
@lyrixx
Copy link
Member

lyrixx commented Feb 17, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@welcoMattic welcoMattic welcoMattic approved these changes

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damienalexandre @lyrixx @welcoMattic @Korbeil