Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

int priority parameters should be changed to string (on api generator level) #28

Closed
egulhan opened this issue Apr 20, 2019 · 0 comments · Fixed by #35
Closed

int priority parameters should be changed to string (on api generator level) #28

egulhan opened this issue Apr 20, 2019 · 0 comments · Fixed by #35

Comments

@egulhan
Copy link

egulhan commented Apr 20, 2019

priority parameters' type is integer but in some cases priority values return as float from slack api and it gives this error: ObjsGroup::setPriority() float given error.
egulhan pushed a commit to egulhan/slack-php-api that referenced this issue Apr 20, 2019
FIX - jolicode#28 - change int type priority parameters
85545c1 
to string
@egulhan egulhan mentioned this issue Apr 20, 2019
Closed
egulhan added a commit to egulhan/slack-php-api that referenced this issue Apr 20, 2019
@egulhan
Merge branch 'fix-jolicode#28-type-int-priority-to-type-string' into …
944dc84 
…egulhan-v1.1-fixes
damienalexandre added a commit that referenced this issue Apr 23, 2019
@damienalexandre
Fix #28, switch priority from integer to float
13564a8
@damienalexandre damienalexandre mentioned this issue Apr 23, 2019
Merged
damienalexandre added a commit that referenced this issue Apr 23, 2019
@damienalexandre
Merge pull request #35 from jolicode/fix/28
cea7879 
Fix #28, switch priority from integer to float
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #28, switch priority from integer to float jolicode/slack-php-api
1 participant
@egulhan