Upgrade JanePHP and rebuild the classes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
approved these changes
Mar 12, 2021
akuzia
reviewed
Sep 16, 2022
| @@ -61,7 +61,8 @@ public function executeEndpoint(Endpoint $endpoint, string $fetch = self::FETCH_ | |||
| $request = $request->withBody($body); | |||
| } elseif (\is_resource($body)) { | |||
| $request = $request->withBody($this->streamFactory->createStreamFromResource($body)); | |||
| } elseif (is_file($body)) { | |||
| } elseif (\strlen($body) <= 4000 && is_file($body)) { | |||
| // more than 4096 chars will trigger an error | |||
There was a problem hiding this comment.
@damienalexandre what's the matter with 4096 chars?
There was a problem hiding this comment.
As stated in the PR description,
Calling is_file with a very long path will throw a PHP error. So this change prevent the error from happening.
Did you get an issue with this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to fix #107 - JanePHP released a minor patch avoiding this kind of error:
Example: https://3v4l.org/6SfuH
This PR upgrade JanePHP and regenerate the client with this fix. Thanks to @Korbeil for the JanePHP fix!