Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team_id support for 3 endpoints #140

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

mpyw
Copy link
Contributor

@mpyw mpyw commented Jan 18, 2022

@mpyw
Copy link
Contributor Author

mpyw commented Jan 18, 2022

@damienalexandre Hi, there are some problems:

  • ./bin/slack-api-client-generator spec:update partially fails and it generates *.rej file.
  • vendor/bin/jane-openapi generate --config-file=.jane-openapi.php gives no effect on SDK about team_id.
  • vendor/bin/jane-openapi generate --config-file=.jane-openapi.php gives effect which makes some token parameter required.

They look wrong, what should I do next?

@damienalexandre
Copy link
Member

Hey!

I think something went wrong, I tried it locally and it was fine, here is what I did:

# get your first commit
git cherry-pick 5f17c6f
# remove existing SDK
rm -Rf generated/*
# build new SDK with team ID
vendor/bin/jane-openapi generate --config-file=.jane-openapi.php
# run the tests and check the code (team id is here!)
vendor/bin/simple-phpunit
# update the patch file automatically
./bin/slack-api-client-generator spec:generate-patch
# check the patch is valid
./bin/slack-api-client-generator spec:update

That's it - you can then just commit the result.

@mpyw mpyw marked this pull request as ready for review January 24, 2022 02:25
@mpyw mpyw changed the title [WIP] Add team_id support for 3 endpoints Add team_id support for 3 endpoints Jan 24, 2022
@mpyw
Copy link
Contributor Author

mpyw commented Jan 24, 2022

@damienalexandre Thanks for the heads up! It is ready for review now

@damienalexandre
Copy link
Member

Looks good now! Thanks a lot for this contribution, that helps a lot 😋

@damienalexandre damienalexandre merged commit 2b0f5cf into jolicode:main Jan 24, 2022
@mpyw mpyw deleted the fix/team_id branch January 25, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UsersList and UsergroupsList should accept new parameter: "team_id"
2 participants