The "ts" field could be seen as an integer, we must allow string and number #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> TypeError: Argument 1 passed to JoliCode\Slack\Api\Model\ObjsMessageAttachmentsItem::setTs() must be of the type string or null, integer given, called in /home/dalexandre/Dev/slack-php-api/generated/Normalizer/ObjsMessageAttachmentsItemNormalizer.php on line 108
damienalexandre
added a commit
that referenced
this pull request
Apr 23, 2019
The "ts" field could be seen as an integer, we must allow string and number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got this error while testing #23:
That's hard to reproduce but sometime the Slack API will return a valid integer, so we can't rely on PHP strict type for those "ts" fields.
This PR fix this and also fix the patch format. cc @pyrech