Skip to content
This repository has been archived by the owner on Jul 25, 2023. It is now read-only.

refactor: put cows in tag implementation 🐮 #111

Merged
merged 4 commits into from Jul 7, 2023
Merged

refactor: put cows in tag implementation 🐮 #111

merged 4 commits into from Jul 7, 2023

Conversation

jdrouet
Copy link
Contributor

@jdrouet jdrouet commented Jul 7, 2023

No description provided.

Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #111 (2f71f30) into main (7d9159a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files         218      218           
  Lines       11641    11652   +11     
=======================================
+ Hits        10809    10820   +11     
  Misses        832      832           
Impacted Files Coverage Δ
src/helper/tag.rs 100.00% <100.00%> (ø)
src/mj_accordion/render.rs 95.86% <100.00%> (ø)
src/mj_accordion_text/render.rs 100.00% <100.00%> (ø)
src/mj_accordion_title/render.rs 100.00% <100.00%> (ø)
src/mj_body/render.rs 94.80% <100.00%> (ø)
src/mj_carousel/render.rs 96.92% <100.00%> (ø)
src/mj_carousel_image/render.rs 99.44% <100.00%> (+0.01%) ⬆️
src/mj_navbar/render.rs 96.31% <100.00%> (ø)
src/mj_social_element/render.rs 97.88% <100.00%> (ø)
src/mj_text/render.rs 100.00% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@jdrouet jdrouet marked this pull request as ready for review July 7, 2023 08:57
@jdrouet
Copy link
Contributor Author

jdrouet commented Jul 7, 2023

This brings an important performance boost compared to the main branch

     Running benches/basic.rs (target/release/deps/basic-52da3f260592e45e)
render button           time:   [28.042 µs 28.095 µs 28.153 µs]
                        change: [-28.223% -27.974% -27.738%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

     Running benches/template.rs (target/release/deps/template-7140c660f814986a)
Benchmarking amario: Warming up for 3.0000 s
amario                  time:   [1.0883 ms 1.0894 ms 1.0907 ms]
                        change: [-22.986% -22.823% -22.667%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)

@jdrouet jdrouet merged commit 74b7564 into main Jul 7, 2023
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant