fix: resolve react and react-dom dependency conflicts #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification of react and react-dom @18 causes npm to pull a version of react at that version within the package directory. This causes a runtime issue if this is not the version of react that is actually used by consumers when they attempt to serve those dependencies without the version matching. `peerDependencies` suggests that this package should be compatible with react and react-dom @17 as well, so the expectation is that consumers can use v17 of those dependencies. `peerDependencies` already specify react and react-dom @17/@18, so the necessity of these packages is already conveyed to consuming packages. `devDependencies` already specifies react and react-dom @18 for use for development of this package. Closes jollyjerr#26
|
If necessary, I can construct a minimum reproduction repo; however, my test case was an issue at work, so I don't have one off hand. We worked around that by using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification of react and react-dom @18 causes npm to pull a version of react at that version within the package directory. This causes a runtime issue if this is not the version of react that is actually used by consumers when they attempt to serve those dependencies without the version matching.
peerDependenciessuggests that this package should be compatible with react and react-dom @17 as well, so the expectation is that consumers can use v17 of those dependencies.peerDependenciesalready specify react and react-dom @17/@18, so the necessity of these packages is already conveyed to consuming packages.devDependenciesalready specifies react and react-dom @18 for use for development of this package.Closes #26