Merge pull request #446 from jolocom/release/v5.1.0

Release/v5.1.0

.eslintrc.js

@@ -13,14 +13,34 @@ module.exports = {
     'plugin:prettier/recommended',
   ],
   rules: {
-    'no-restricted-syntax': [
-      'error',
-      {
-        selector: 'ExportDefaultDeclaration',
-        message: 'Prefer named exports',
-      },
-    ],
-    '@typescript-eslint/array-type': ['error', 'array-simple'],
+    'arrow-body-style': ['warn', 'as-needed'],
+    // curly braces for if, else etc.
+    curly: ['error', 'multi-line'],
+    'default-case': ['error'],
+    eqeqeq: ['error', 'smart'],
+    // for...in will normally include properties in prototype chain, require if
+    'guard-for-in': ['error'],
+    // I don't think we even use labels
+    'no-extra-label': ['error'],
+    // not sure about this, but replaces tslint's `no-arg` rule
+    'no-caller': ['error'],
+    // transfered from tslint's `no-conditional-assignment` rule
+    'no-cond-assign': ['error'],
+    'no-debugger': ['error'],
+    // similar to tslint's `no-construct` rule
+    'no-new-wrappers': ['error'],
+    // replacement for `no-string-throw`
+    'no-throw-literal': ['error'],
+    'no-unused-expressions': ['error'],
+    'no-var': ['error'],
+    // this isn't a tslint thing, but have copied over
+    'new-parens': ['error'],
+    'object-shorthand': ['error'],
+    'prefer-arrow-callback': ['error'],
+    'prefer-const': ['error'],
+    semi: ['error', 'never'],
+    'use-isnan': ['error'],
+    '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
     '@typescript-eslint/ban-types': [
       'error',
       {
@@ -33,13 +53,31 @@ module.exports = {
       },
     ],
     // PascalCase for classes
-    '@typescript-eslint/class-name-casing': ['error'],
-    // allow 'I' prefix to interface names
-    '@typescript-eslint/interface-name-prefix': ['off'],
+    '@typescript-eslint/naming-convention': ['error'],
+    // don't prefix interface names with 'I'
+    '@typescript-eslint/naming-convention': ['warn'],
+    // lose out on typing benefits with any
+    '@typescript-eslint/no-explicit-any': ['warn'],
+    '@typescript-eslint/no-empty-interface': ['off'],
     '@typescript-eslint/no-inferrable-types': ['error'],
     // namespaces and modules are outdated, use ES6 style
     '@typescript-eslint/no-namespace': ['error'],
+
+    '@typescript-eslint/no-var-requires': ['off'],
+    '@typescript-eslint/no-use-before-define': ['off'],
+    '@typescript-eslint/explicit-function-return-type': ['off'],
+
+    // Avoid Promise based foot-shooting
+    '@typescript-eslint/promise-function-async': ['error'],
+    '@typescript-eslint/no-floating-promises': ['error'],
+    '@typescript-eslint/no-misused-promises': ['error'],
+
+
+    // these seem to be out of date
     // use ES6-style imports instead
-    '@typescript-eslint/no-triple-slash-reference': ['error'],
+    // '@typescript-eslint/no-triple-slash-reference': ['error'],
+    // don't conflict <Types> and JSX
+    // '@typescript-eslint/no-angle-bracket-type-assertion': ['error'],
+
   },
 }

.mocharc.json

@@ -0,0 +1,5 @@
+{
+  "extension": ["ts"],
+  "spec": "./tests/**/*.test.ts",
+  "require": "ts-node/register"
+}

.nycrc

@@ -0,0 +1,4 @@
+{
+    "extends": "@istanbuljs/nyc-config-typescript",
+    "all": true
+}