Skip to content

Commit

Permalink
Documentation clarifications based on review
Browse files Browse the repository at this point in the history
  • Loading branch information
skarsaune committed Jul 6, 2020
1 parent c5d7ee2 commit 2c1af94
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Expand Up @@ -9,7 +9,7 @@
import org.jolokia.client.jmxadapter.JolokiaJmxConnector;

/**
* I provide support for handling JMX urls over the Jolokia protocol to JVMs running in kubernetes pods
* This provides support for handling JMX urls over the Jolokia protocol to JVMs running in kubernetes pods
* Syntax examples
* <ul>
* <li>service:jmx:kubernetes:///api/v1/namespaces/mynamespace/pods/mypodname-.+/actuator/jolokia/</li>
Expand All @@ -18,9 +18,9 @@
*
* Regular expressions in service url is supported so you can have working URLs across deploys.
* Regular expression URLs will connect to the first pod/service that matches expession.
* Prerequesite: You should have <code>kubectl</code> installed and have valid credentiatls for k8s cluster
* readily stored under $HOME/.kube/config
* My Jar contains a service loader, so that Jolokia JMX protocol is supported
* Prerequesite: You should have configuration and valid credentiatls for k8s cluster
* readily in place, so you have access to the kubernetes api. You can validate this independently with a tool such as kubectl.
* This jar file contains a service loader, so that Jolokia JMX protocol is supported
* as long as my jar (jmx-adapter-version-standalone.jar) is on the classpath
*
* <pre>
Expand Down
Expand Up @@ -35,8 +35,8 @@
import org.apache.http.protocol.HttpContext;

/**
* I implement a minimum support of the HttpClient interface
* based on what is used by J4PClient hence I need to adapt
* This is a minimum implementation of the HttpClient interface
* based on what is used by J4PClient hence the need to adapt
* One HTTP client to another HTTP client API
*/
public class MinimalHttpClientAdapter implements HttpClient {
Expand Down

0 comments on commit 2c1af94

Please sign in to comment.