Make KeyStoreUtil.updateWithServerPems load the full cert chain #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updateWithServerPems uses CertificateFactory.GenerateCertificate(), which only loads the first certificate in the server certificate file. When using a certificate that is signed by an intermediate CA (like Let's Encrypt,) this would result in a certifiacte that won't be accepted by clients that only has the root CA, and not the intermediate CA, in their trusted certificates stores. This replaces that call with a call to CertificateFactory.GenerateCertificates(), that loads the full chain, allowing clients with just the root chain to trust the server. Signed-off-by: Shay Elkin <shay@elkin.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateWithServerPems uses CertificateFactory.GenerateCertificate(), which only loads the first certificate in the server certificate file. When using a certificate that is signed by an intermediate CA (like Let's Encrypt,) this would result in a certifiacte that won't be accepted by clients that only has the root CA, and not the intermediate CA, in their trusted certificates stores.
This replaces that call with a call to CertificateFactory.GenerateCertificates(), that loads the full chain, allowing clients with just the root chain to trust the server.