Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Note support for cookies in documents #100

Closed
fzyzcjy opened this issue Jul 6, 2018 · 3 comments
Closed

Suggestion: Note support for cookies in documents #100

fzyzcjy opened this issue Jul 6, 2018 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@fzyzcjy
Copy link

fzyzcjy commented Jul 6, 2018

Thank you for your wonderful project! I have a small suggestion: Currently, the documentation does not say anything about cookie support (I tried to ctrl+F to search "cookie" but failed). However, after some experiment, I find that it automatically shares the cookie in react native. It is very helpful for those applications based on cookies such as authentication. Therefore, I suggest that the document add several sentences, explicitly saying that it has cookie support.
@Traviskn
Copy link

We are open to PRs both to our README and our Wiki, I'd be glad to accept a PR to update our docs 😃

@Traviskn Traviskn added the help wanted Extra attention is needed label Jul 11, 2018
@fzyzcjy
Copy link
Author

fzyzcjy commented Jul 11, 2018

OK I will do that 😃

@fzyzcjy fzyzcjy mentioned this issue Jul 12, 2018
Merged
@fzyzcjy
Copy link
Author

fzyzcjy commented Jul 12, 2018

created #110 😃

@fzyzcjy fzyzcjy closed this as completed Jul 14, 2018
cguino pushed a commit to BeApp/rn-fetch-blob that referenced this issue Jul 5, 2023
Update:
dea7c81 
* Media store support

fixes joltup#95
fixes joltup#62
fixes joltup#100
fixes joltup#91
Merge remote-tracking branch 'origin/develop'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Traviskn @fzyzcjy