Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX proper use-case following kie-server marshalling requirements #1

Merged

Conversation

tarilabs
Copy link

@tarilabs tarilabs commented Jun 4, 2020

No description provided.

@tarilabs
Copy link
Author

tarilabs commented Jun 4, 2020

@jomarko please merge with squash.

@jomarko jomarko merged commit 14054f7 into jomarko:JBPM-9173 Jun 4, 2020
@jomarko
Copy link
Owner

jomarko commented Jun 4, 2020

@tarilabs thank you, so what does it mean for customer, do they need o start kie server with some configuration pointing to class they want to marshall?

@tarilabs
Copy link
Author

tarilabs commented Jun 4, 2020

@jomarko this comment should summarise the reasons behind this code, is just one of the many example how to use standard best-practices of kie-server marshalling.
https://issues.redhat.com/browse/RHDM-1364?focusedCommentId=14135922&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14135922

jomarko pushed a commit that referenced this pull request Jan 11, 2021
…on (kiegroup#2107)

* JBPM-9173: Create reproducer test for dmn date on kie server evaluation

This PR is not a fix.
For more details see: https://issues.redhat.com/browse/JBPM-9173

* FIX proper use-case following kie-server marshalling requirements (#1)

* FIX proper use-case following kie-server marshalling requirements

* avoid anti-pattern of using `today()` which is not pure Fn in tests.

Co-authored-by: Matteo Mortari <matteo.mortari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants