Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add partial support for unique_id database property #135

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

nickysemenza
Copy link
Contributor

https://www.notion.so/help/unique-id it is newly released so their API docs don't have any information yet. Therefore I'm unable to determine the correct implementation for updates, but this works for the read use case - my app started failing with unsupported property type: unique_id and this remediates that.

prefix is optional, notion api response looks like either:

"unique_id": {
                        "prefix": null,
                        "number": 308
                    }

or

"unique_id": {
                        "prefix":"FOO",
                        "number": 308
                    }

https://www.notion.so/help/unique-id it is newly released so their API docs don't have any information yet. Therefore I'm unable to determine the correct implementation for updates, but this works for the read use case - my app started failing with `unsupported property type: unique_id` and this remediates that.

prefix is optional, notion api response looks like either:
```
"unique_id": {
                        "prefix": null,
                        "number": 308
                    }
```
or
```
"unique_id": {
                        "prefix":"FOO",
                        "number": 308
                    }
```
Copy link
Owner

@jomei jomei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jomei jomei merged commit 8c59d8a into jomei:main Jun 1, 2023
1 check passed
@nickysemenza nickysemenza deleted the unique_id branch June 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants