This repository has been archived by the owner on Dec 24, 2021. It is now read-only.
Add flash intensity #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge PR #15 first!
Adds an intensity parameter to the flashon and capture_with_flashlight commands.
It's controlled via LEDC.
It's useful if you your picture with internal flashlight is too bright and the light causes too many reflections.
Default is set up to use channel 2 and a resolution of 12 bit which worked best for me. Channel 0 and 1 gave unexpected results.
12 bit means:
intensity = 0: off
intensity = 1: lowest
intensity = 4095: highest - comparable to digital HIGH before.
I have to admit that I obviously changed the one or the other line according to style. This is mostly done by the editor and auto correction. I left it where I think it's feasible.
A styleguide would be helpful since I can't gather the coding style of the whole project (sometimes 2 or 4 space indentation, sometimes more, etc.