Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Create Billplz\PaymentCompletion class to handle callback and redirect urls when creating bills. #43

Merged
merged 6 commits into from
Dec 13, 2019

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Dec 10, 2019

Current Behaviour.

use Duit\MYR;

$response = $bill->create(
    'inbmmepb',
    'api@billplz.com',
    null,
    'Michael API V3',
    MYR::given(200),
    ['callback_url' => 'http://example.com/webhook/', 'redirect_url' => null],
    'Maecenas eu placerat ante.'
);

New Behaviour

use Billplz\PaymentCompletion;
use Duit\MYR;

$response = $bill->create(
    'inbmmepb',
    'api@billplz.com',
    null,
    'Michael API V3',
    MYR::given(200),
    new PaymentCompletion('http://example.com/webhook/', null),
    'Maecenas eu placerat ante.'
);

Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com

redirect urls when creating bills.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@coveralls
Copy link

coveralls commented Dec 10, 2019

Pull Request Test Coverage Report for Build 750

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 738: 0.0%
Covered Lines: 185
Relevant Lines: 185

💛 - Coveralls

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone added this to the v4.0.0 milestone Dec 10, 2019
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone merged commit 9f42785 into master Dec 13, 2019
@crynobone crynobone deleted the payment-completion branch December 27, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants