Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doc - Set Redirect URL to optional parameters #47

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

rootchips
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 840

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 839: 0.0%
Covered Lines: 185
Relevant Lines: 185

💛 - Coveralls

@crynobone
Copy link
Member

crynobone commented Jun 27, 2020

Both structure can be used. The current structure in the doc is actually preferred.

@rootchips
Copy link
Contributor Author

rootchips commented Jun 28, 2020

Salam Tuan @crynobone. Thanks for reply. Sorry for didn't provide the description in the comment earlier.

I tried to create bill and did follow the current structure for alternative way to set redirect url in array like

['callback_url' => 'http://example.com/webhook/', 'redirect_url' => 'http://example.com/redirect/']

But it throws an error Argument 1 passed to Billplz\PaymentCompletion::__construct() must be of the type string, array given, called in /project/vendor/jomweb/billplz/src/Base/Bill.php on line 50

Is 4.x branch can be used for this alternative?

@crynobone
Copy link
Member

My mistake, the alternative method is by using new Billplz\PaymentCompletion($callbackUrl, $redirectUrl)

@crynobone crynobone merged commit 5c9171a into jomweb:4.x Jun 28, 2020
@rootchips rootchips deleted the fix-doc branch June 28, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants