Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display template is faulty #91

Closed
jon-harper opened this issue Jan 10, 2023 · 4 comments
Closed

Display template is faulty #91

jon-harper opened this issue Jan 10, 2023 · 4 comments
Assignees
Labels
bug Something isn't working Display Involving a display mount, panel, or support

Comments

@jon-harper
Copy link
Owner

jon-harper commented Jan 10, 2023

A user reported that the display template has the wrong mounting hole locations. The template is inherited from Steve's project, so it very well may never have been updated.

@jon-harper jon-harper added bug Something isn't working Display Involving a display mount, panel, or support labels Jan 10, 2023
@jon-harper jon-harper self-assigned this Jan 10, 2023
@MaffooClock
Copy link
Contributor

MaffooClock commented Jan 17, 2023

I used this template for my BTT Pi TFT50 display (#88), and while those components fit together perfectly, I did notice the mounting holes in the corners were slightly off from those in the main body; ~1-2mm vertically inward (horizontal spacing lines up fine).

I started to bring this up, but figured it might be possible that my main body component warped slightly during printing, so I didn't want to say anything until I was certain. I wanted to check the design file for the main body to see what the vertical distance is between mounting holes to compare with those in the template (and my designed based off that), but I don't see a .f3d or .step file.

I'll hold off on submitting a PR for #88 until we can confirm correct spacing.

@jon-harper
Copy link
Owner Author

Thank you for checking on this; there are a couple of entangled display bugs/requests here I need to sort out. I intend to pare down the bug list later this week, hopefully knock this one out, and get some new stuff merged. 😄

jon-harper added a commit that referenced this issue Jan 22, 2023
Screw holes were definitely off, probably from v0.9.5 -> 0.9.7.
@MaffooClock
Copy link
Contributor

MaffooClock commented Jan 23, 2023

Now that you got this sorted out, what is the vertical distance between screw holes supposed to be? As a test, I re-printed my BTT Pi TFT50 with 103mm vertical distance, and it was spot-on (horizontal distance was unchanged). In fact, due to the way the constraints were setup, adding the extra millimeter also increased the overall height of the panel, which ended up making a perfect fit overall.

I'll submit a PR for the new display panel once I know the correct measurement 👍

@jon-harper
Copy link
Owner Author

jon-harper commented Jan 23, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Display Involving a display mount, panel, or support
Projects
None yet
Development

No branches or pull requests

2 participants