Skip to content

Commit

Permalink
Change standalone debugger to no longer limit number of bundles
Browse files Browse the repository at this point in the history
The maintenance of having a streamlined standalone debugger that
starts as fast as possible is no longer possible. See for
example eclipse-cdt#591 - therefore when using standalone debugger, use
the same sets of plug-ins/features as the product it is installed
in uses. The side effect is that the standalone debugger in this
use case will start slower and extra "stuff" will be present in
this UI.

For people just building the standalone debugger, provide a minimum
feature set. This will be many more bundles than before, but
should still provide a reasonably small set that starts well.

This simplification also includes removing the the duplicates set
of CDT docs (debug/org.eclipse.cdt.debug.application.doc). These
provided a simplified version of CDT's documentation targetted
at just standalone debugger. However there are a few problems related
to this duplication:

- The two sets of docs were not kept in sync
- The standalone docs appear in the online help, leading to
  duplicated entries
- With the config.ini changes above, there is no way to exclude
  the main docs in the standalone case, so remove the duplicate

A number of directly related clean-ups are included too:

- Remove the `ConfigGenerator.java` that stopped being referenced
  in PR eclipse-cdt#761
- Complete the removal of `build-standalone-debugger-rcp` profile
  that was started in eclipse-cdt#761. There is a small drawback to not having
  this profile, the standalone debugger is very slow to build
  compared to the rest of CDT. If this becomes a problem, restoring
  this profile along with the changes made in eclipse-cdt#761 is reasonable.
- bring debug.product's licenses up to date
- modernize command line args to eclipse when using debug.product

Fixes eclipse-cdt#781
  • Loading branch information
jonahgraham committed May 12, 2024
1 parent 5f2fcd0 commit 89667cd
Show file tree
Hide file tree
Showing 685 changed files with 184 additions and 22,700 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
clean verify -B -V \
-Dmaven.test.failure.ignore=true \
-DexcludedGroups=flakyTest,slowTest \
-P build-standalone-debugger-rcp \
-Ddsf.gdb.tests.timeout.multiplier=50 \
-Ddsf-gdb.skip.tests=$(test ${{ steps.filter.outputs.dsf }} == 'false' && echo 'true' || echo 'false') \
-Dindexer.timeout=300
Expand Down
5 changes: 0 additions & 5 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ Individual p2 repos can be turned on and off to allow building CDT, or parts of
- test CDT against a pre-built CDT by using the cdtRepo profile.
- build the standalone rcp debugger against the latest simrel `mvn verify -DuseSimrelRepo -f debug/org.eclipse.cdt.debug.application.product`

#### build-standalone-debugger-rcp

Using the `build-standalone-debugger-rcp` profile will include the standalone debugger, located
in `debug/org.eclipse.cdt.debug.application.product`

#### skip-all-tests, skip-tests-except-cdt-ui, skip-tests-except-dsf-gdb, skip-tests-except-cdt-other

Using any of the above profiles can skip large sets of tests. The CI build uses this to parallelize tests. See https://ci.eclipse.org/cdt/view/Gerrit/
Expand Down
1 change: 0 additions & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ pipeline {
-Ddsf.gdb.tests.timeout.multiplier=50 \
-Dindexer.timeout=300 \
-P production \
-P build-standalone-debugger-rcp \
-Ddsf.gdb.tests.gdbPath=/shared/common/gdb/gdb-all/bin \
-Dcdt.tests.dsf.gdb.versions=gdb.10,gdbserver.10 \
-Dmaven.repo.local=/home/jenkins/.m2/repository \
Expand Down
1 change: 0 additions & 1 deletion debug/org.eclipse.cdt.debug.application.doc/.gitignore

This file was deleted.

22 changes: 0 additions & 22 deletions debug/org.eclipse.cdt.debug.application.doc/.project

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

38 changes: 0 additions & 38 deletions debug/org.eclipse.cdt.debug.application.doc/about.html

This file was deleted.

61 changes: 0 additions & 61 deletions debug/org.eclipse.cdt.debug.application.doc/book.css

This file was deleted.

0 comments on commit 89667cd

Please sign in to comment.